Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-12173: Add windows-capabilities and windows-optional-features modules #104

Conversation

craigcomstock
Copy link
Contributor

No description provided.

@craigcomstock craigcomstock marked this pull request as draft September 19, 2024 21:51
Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile review, so super weak. Looks ok. But i can do a better look through tomorrow when at desk

@craigcomstock craigcomstock force-pushed the ENT-12173-windows-capabilities-optional-features branch from 4ea4b7f to 0f78a78 Compare October 3, 2024 21:46
@craigcomstock craigcomstock marked this pull request as ready for review October 3, 2024 21:56
@craigcomstock craigcomstock force-pushed the ENT-12173-windows-capabilities-optional-features branch 2 times, most recently from d3854c0 to 5658313 Compare October 4, 2024 14:06
Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice, just a few minor suggestions for the future really.

@craigcomstock craigcomstock force-pushed the ENT-12173-windows-capabilities-optional-features branch from 5658313 to b1ac331 Compare October 4, 2024 15:16
@craigcomstock craigcomstock force-pushed the ENT-12173-windows-capabilities-optional-features branch 2 times, most recently from 38ce196 to ba65de3 Compare October 4, 2024 15:36
@craigcomstock craigcomstock force-pushed the ENT-12173-windows-capabilities-optional-features branch from ba65de3 to bd14392 Compare October 4, 2024 15:40
@craigcomstock
Copy link
Contributor Author

testing using this module PR commit in my-cfbs project and re-installing openssh server capability and service and containers optional feature. Then I will merge and make the PR for build-index.

@craigcomstock craigcomstock merged commit 9daca3b into cfengine:master Oct 4, 2024
@craigcomstock craigcomstock deleted the ENT-12173-windows-capabilities-optional-features branch October 4, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants